Igalia / acacia

Library for inspecting accessibility APIs
https://igalia.github.io/acacia
GNU Lesser General Public License v2.1
8 stars 1 forks source link

Atspi Reference Counting #133

Closed spectranaut closed 8 months ago

spectranaut commented 8 months ago

Related to this issue: https://github.com/Igalia/AXAccess/pull/131/files/d7c70aca1c7949a4d2b6ef8feb9a2c4c6f333d47#r1523813558

Joanie searched the atspi code and found it does potentially reference:

static void
atspi_accessible_unref (GObject *accessible)
{
  if (accessible != NULL)
    g_object_unref (accessible);
}
static void
atspi_object_dispose (GObject *object)
{
  AtspiObject *aobj = ATSPI_OBJECT (object);

  if (aobj->app)
    {
      g_object_unref (aobj->app);
      aobj->app = NULL;
    }

  G_OBJECT_CLASS (atspi_object_parent_class)->dispose (object);
}

https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/main/atspi/atspi-accessible.c#L196

spectranaut commented 8 months ago

@elima you looked into this and found no memory leaks so I think we can close this issue?

elima commented 8 months ago

Yeah, I think we can close this issue until we find new problems (either leaks or crashes :)).