search

Igalia / acacia

Library for inspecting accessibility APIs
https://igalia.github.io/acacia
GNU Lesser General Public License v2.1
8 stars 1 forks source link

Implement Copy{Bool,Int,Float,URL,Node,Point,Size,Rect,Range,StringList,RangeList,DictionaryList}AttributeValue() #139

Closed alice closed 8 months ago

alice commented 8 months ago

Also, update dump_tree_mac.cc to actually dump a tree, and use the new getters, made some improvements to ScopedCFTypeRef, split mac code out more, added relevant types, general cleanup. Phew!

alice commented 8 months ago

@spectranaut Sorry, this just kept growing and growing because I wanted to get it done before you went away, but now you've got this mega review to do on top of whatever else, so don't worry to much if it has to wait till you get back. If that happens, I'll also have time to split it out into more manageable chunks to review...

alice commented 8 months ago

One thing I noticed (but don't have time to dig into, sorry!) when running attribute_types.cc: ... What are these attributes without a type, or a null string? I don't even understand how this could have happened. This comes up for me dumping google chrome from the main page: Version 123.0.6312.58 (Official Build) (arm64)

Ohhh that was a mistake on my part! I tried to avoid storing types for empty lists since we can't deduce a type for a list with no elements to look at, but instead I just stored an empty string 🤦

Fixed!

Re all your naming suggestions - I think they're a good idea, but I'll make a separate PR since this one is already a beast.