Igalia / acacia

Library for inspecting accessibility APIs
https://igalia.github.io/acacia
GNU Lesser General Public License v2.1
8 stars 1 forks source link

Put all of the linux code in acacia namespace #202

Closed spectranaut closed 7 months ago

spectranaut commented 7 months ago

Alice I tried to fit this one in before going on vacation -- but I'm getting errors when generating both nodejs and python binding:

../acacia_atspi_nodejs_wrap.cxx:4642:3: error: ‘AtspiTableInterface’ was not declared in this scope; did you mean ‘acacia::AtspiTableInterface’?
 4642 |   AtspiTableInterface result;
      |   ^~~~~~~~~~~~~~~~~~~
      |   acacia::AtspiTableInterface

I thought according to the SWIG does this should just work! Anyway, I'll look when I get back.

alice commented 7 months ago

@spectranaut I've been poking around on Linux, so I had a look at this and found the Stack Overflow post explaining the necessary incantation for SWIG to find the namespace (pretty self-explanatory when you look at it).

Also, while I was testing that, I realised the order of %includes is important - they have to be in dependency order, otherwise you get weird issues with interfaces not being found. So I fixed that as well.