search

Igalia / chromium

Old repo. See https://crbug.com/578890 instead.
https://chromium.googlesource.com/chromium/src.git
BSD 3-Clause "New" or "Revised" License
115 stars 16 forks source link

Ozone wayland dev refactoring file #442

Closed jkim-julie closed 6 years ago

jkim-julie commented 6 years ago

@msisov, FileSelectExtension at #413 was rebased with ozone-wayland-dev-refactoring branch.

As taking minimum features from ChromeOS, it has several limitations.

It doesn't support Image Preview.(We can add it later, if we want)
It doesn't support Zip/Unzip.(We can add it later, if we want)
It shows Downloads folder for now.(In order to explorer home or root, further investigation is required.)
It doesn't support MTP and external or removable storage.(Further investigation is required.)
It doesn't support SMB(file system provider, https://blog.chromium.org/2015/06/file-system-provider-api-for-easier.html)
unit_tests and browser_tests are enabled only on ChrmoeOS.(It has some dependency on MTP, Disk Manager or other features not enabled on linux desktop.)

It doesn't removed file manager from chromeos in order to make rebase with the latest code and comparing to original easier.

PTAL.

jkim-julie commented 6 years ago

I don't know the reason but I couldn't add reviewer. If you leave comment, I'll check.

msisov commented 6 years ago

you did a great job for this. Thanks. But there is a big but... Guys from the file extension team for chromeos won't accept such a big change. AFAIK, we were said that we better implement own webui extension rather than reuse this. In any case, let's keep this as it is, and decide what to do during upstreaming.

@tonikitoo, wdyt?

jkim-julie commented 6 years ago

It will be rebased with the latest branch and I will create a new PR to 'ozone-wayland-dev' branch.