search

Igalia / chromium

Old repo. See https://crbug.com/578890 instead.
https://chromium.googlesource.com/chromium/src.git
BSD 3-Clause "New" or "Revised" License
115 stars 16 forks source link

[ozone/headless] Add HeadlessNativeDisplayDelegate. #450

Closed jkim-julie closed 6 years ago

jkim-julie commented 6 years ago

This CL created HeadlessNativeDisplayDelegate for ozone/headless. DesktopScreenOzone keeps it at delegate_ and communicate it.

With thie CL, we can launch chromium with '--ozone-platform=headless'.

jkim-julie commented 6 years ago

@msisov, HeadlessNativeDisplayDelegate is created. When I checked headless without ozone, window size is set with defalut value at https://cs.chromium.org/chromium/src/headless/public/headless_browser.cc?rcl=28b6d51b55308bc3d8562414859640161d0d3e93&l=50 and can be set with command line argument, at https://cs.chromium.org/chromium/src/headless/public/headless_browser.cc?rcl=28b6d51b55308bc3d8562414859640161d0d3e93&l=160

And then HeadlessScreen is created at https://cs.chromium.org/chromium/src/headless/lib/browser/headless_browser_impl_aura.cc?rcl=28b6d51b55308bc3d8562414859640161d0d3e93&l=23 and it calls SetScreenInstance().

This CL doesn't include the part for respecting argument window size. I need to consider how to make it.

PTAL.

jkim-julie commented 6 years ago

@msisov , the branch was updated. PTAL.

jkim-julie commented 6 years ago

Updated branch and fixed nits.