search

Igalia / chromium

Old repo. See https://crbug.com/578890 instead.
https://chromium.googlesource.com/chromium/src.git
BSD 3-Clause "New" or "Revised" License
115 stars 16 forks source link

Unit tests for wayland buffer manager are introduced. #519

Closed alex-voodoo closed 5 years ago

alex-voodoo commented 5 years ago

This is the first step for resolving https://bugs.chromium.org/p/chromium/issues/detail?id=873132

msisov commented 5 years ago

please resolve the following problem produced by gn args out/OzoneLinux --check:

[08:25:43] 1. Start compiling Chromium on OzoneLinux and targets chrome ozone_unittests ninja: Entering directory `out/OzoneLinux' [1/1] Regenerating ninja files FAILED: build.ninja ../../buildtools/linux64/gn --root=../.. -q --check gen . ERROR at //ui/ozone/platform/wayland/wayland_buffer_fuzzer.cc:19:11: Include not allowed.

include "base/test/fuzzed_data_provider.h"

      ^-------------------------------

It is not in any dependency of //ui/ozone/platform/wayland:wayland_buffer_fuzzer The include file is in the target(s): //base/test:test_support which should somehow be reachable.

ERROR at //ui/ozone/platform/wayland/wayland_buffer_fuzzer.cc:20:11: Can't include this header from here.

include "ui/ozone/common/linux/drm_util_linux.h"

      ^-------------------------------------

The target: //ui/ozone/platform/wayland:wayland_buffer_fuzzer is including a file from the target: //ui/ozone/common/linux:drm

It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers.

Dependency chain (there may also be others): //ui/ozone/platform/wayland:wayland_buffer_fuzzer --> //ui/ozone/platform/wayland:wayland --[private]--> //ui/ozone/common/linux:drm

ninja: error: rebuilding 'build.ninja': cannot make progress due to previous errors

[08:25:53] 2. Finish to compile Chromium.

msisov commented 5 years ago

Looks good, please squash them into one commit and let's push this pr.