wpewebkit: tweak runtime dependencies/recommendations

Igalia / meta-webkit

Yocto / OpenEmbedded layer for WebKit based engines and browsers

MIT License

127 stars 70 forks source link

wpewebkit: tweak runtime dependencies/recommendations #318

Closed aperezdc closed 3 years ago

aperezdc commented 3 years ago

The remote inspector support has a hard requirement on the plugin, and the plugin hard-requires shared-mime-info or otherwise resources served by the remote inspector won't include a Content-Type header and the client will fail to load them.

Reflect the above by making wpewebkit-web-inspector-plugin have a runtime dependency on shared-mime-info, and then making wpewebkit depend on wpewebkit-web-inspector-plugin when remote-inspector is enabled in PACKAGECONFIG.

aperezdc commented 3 years ago

One thing that might be better is adding wpewebkit-web-inspector-plugin to the RRECOMMENDS instead of RDEPENDS when runtime-inspector is enabled. Let me know if you would prefer it that way and I'll update the PR 🤔

psaavedra commented 3 years ago

Rebased and merged in https://github.com/Igalia/meta-webkit/pull/323