wpewebkit,webkitgtk: Bump up version to 2.36.3

psaavedra commented 2 years ago

wpewebkit:

Support capturing already encoded video streams, which takes advantage of encoding done in hardware by devices which support this feature.
Avoid using experimental GStreamer elements for video demuxing.
Avoid using the legacy GStreamer VA-API decoding plug-ins, which often cause rendering issues and are not much maintained. Their usage can be re-enabled setting WEBKIT_GST_ENABLE_LEGACY_VAAPI=1 in the environment.
Fix playback of YouTube streams which use dynamic ad insertion.
Fix display capture with Pipewire.
Fix the build without the X11 target when X11 headers are not present.
Fix several crashes and rendering issues.
Release notes: https://wpewebkit.org/release/wpewebkit-2.36.3.html

webkitgtk:

Support capturing already encoded video streams, which takes advantage of encoding done in hardware by devices which support this feature.
Avoid using experimental GStreamer elements for video demuxing.
Avoid using the legacy GStreamer VA-API decoding plug-ins, which often cause rendering issues and are not much maintained. Their usage can be re-enabled setting WEBKIT_GST_ENABLE_LEGACY_VAAPI=1 in the environment.
Fix playback of YouTube streams which use dynamic ad insertion.
Fix display capture with Pipewire.
Fix the build without the X11 target when X11 headers are not present.
Fix several crashes and rendering issues.
Release notes: https://webkitgtk.org/2022/05/28/webkitgtk2.36.3-released.html

aperezdc commented 2 years ago

Beware of https://bugs.webkit.org/show_bug.cgi?id=241109 though! You may want to import the patch once I have it ready.

psaavedra commented 2 years ago

Beware of https://bugs.webkit.org/show_bug.cgi?id=241109 though! You may want to import the patch once I have it ready.

Thanks for the advice. We don't have a CI job for raspberrry 3 or 4 in 64 bits. I just created one for the model 4 in https://github.com/Igalia/meta-webkit/pull/376. I will integrate this MR before this in order to ensure the build error is not happening here.

aperezdc commented 2 years ago

Beware of https://bugs.webkit.org/show_bug.cgi?id=241109 though! You may want to import the patch once I have it ready.

Thanks for the advice. We don't have a CI job for raspberrry 3 or 4 in 64 bits. I just created one for the model 4 in #376. I will integrate this MR before this in order to ensure the build error is not happening here.

That sounds like a good plan 👌🏼. It can happen that with the build settings used the issue won't show up if the unified build compilation units get arranged in a different way than my test builds for Buildroot. The safest would be to apply the patch, but of course that can be done later in a follow-up PR.

psaavedra commented 2 years ago

Beware of https://bugs.webkit.org/show_bug.cgi?id=241109 though! You may want to import the patch once I have it ready.

Thanks for the advice. We don't have a CI job for raspberrry 3 or 4 in 64 bits. I just created one for the model 4 in #376. I will integrate this MR before this in order to ensure the build error is not happening here.

That sounds like a good plan 👌🏼. It can happen that with the build settings used the issue won't show up if the unified build compilation units get arranged in a different way than my test builds for Buildroot. The safest would be to apply the patch, but of course that can be done later in a follow-up PR.

just for curious, do you have -DUSE_ATSPI=ON in the buildroot cmake config line?

github-actions[bot] commented 2 years ago

Pull Request is being checked for https://github.com/Igalia/meta-webkit/pull/375/commits

aperezdc commented 2 years ago

Beware of https://bugs.webkit.org/show_bug.cgi?id=241109 though! You may want to import the patch once I have it ready.

Thanks for the advice. We don't have a CI job for raspberrry 3 or 4 in 64 bits. I just created one for the model 4 in #376. I will integrate this MR before this in order to ensure the build error is not happening here.

That sounds like a good plan 👌🏼. It can happen that with the build settings used the issue won't show up if the unified build compilation units get arranged in a different way than my test builds for Buildroot. The safest would be to apply the patch, but of course that can be done later in a follow-up PR.

just for curious, do you have -DUSE_ATSPI=ON in the buildroot cmake config line?

The USE_ATSPI option is enabled by default when ENABLE_ACCESSIBILITY is enabled. Both Source/cmake/OptionsGTK.cmake and Source/cmake/OptionsWPE.cmake contain:

SET_AND_EXPOSE_TO_BUILD(USE_ATSPI ${ENABLE_ACCESSIBILITY})

For Buildroot's WebKitGTK package accessibility is enabled (which imples USE_ATSPI), while for the WPE WebKit package it's disabled.

psaavedra commented 2 years ago

The new build test for rpi4-64 passes. https://gitlab.com/browsers/meta-webkit/-/jobs/2526168429#L255. I will merge this PR and I will move your proposal to https://github.com/Igalia/meta-webkit/issues/377

Igalia / meta-webkit

wpewebkit,webkitgtk: Bump up version to 2.36.3 #375