Fix dependencies from cog and other recipes with libsoup/libsoup-2.4

psaavedra commented 1 year ago

wpewebkit: Built with libsoup-2.4 or libsoup (version 3) depending on the LAYERSERIES_CORENAMES
webkitgtk: Built with libsoup-2.4 or libsoup (version 3) depending on the LAYERSERIES_CORENAMES
cog: Built with libsoup-2.4 or libsoup (version 3) depending on the LAYERSERIES_CORENAMES
cog: Set runtime dependencies for cog 0.12 according with the Compatibility Components matrix on https://wpewebkit.org/release/schedule/
ci: Update preset for WPE WebKit 2.36.X series
ci: Build target set to cog. We want to be sure that cog and not only wpewebkit can be built with this layer/poky release convination.

psaavedra commented 1 year ago

Recipe for cog 0.14 fails on the configure step on Dunfell:

 CMake Error at cmake/FindWpeFDO.cmake:5 (add_library):
|   add_library cannot create ALIAS target "Wpe::FDO" because target
|   "PkgConfig::WpeFDO" is imported but not globally visible.
| Call Stack (most recent call first):
|   platform/wayland/CMakeLists.txt:28 (find_package)
| 
| 
| -- Found WpeFDO: WPEBackend-fdo-1.0;wpe-1.0;xkbcommon (found version "1.12.0")
| -- Checking for module 'wayland-egl'
| --   Found wayland-egl, version 18.1.0
| -- Checking for module 'wayland-cursor'
| --   Found wayland-cursor, version 1.18.0
| -- Checking for module 'epoxy'
| --   Found epoxy, version 1.5.4
| -- Checking for module 'libdrm>=2.4.71'
| --   Found libdrm, version 2.4.101
| -- Checking for module 'gbm>=13.0'
| --   Found gbm, version 20.0.2
| -- Checking for module 'libinput'
| --   Found libinput, version 1.15.2
| -- Checking for module 'libudev'
| --   Found libudev, version 243
| -- Checking for module 'wayland-server'
| --   Found wayland-server, version 1.18.0
| CMake Error at cmake/FindWpeFDO.cmake:5 (add_library):
|   add_library cannot create ALIAS target "Wpe::FDO" because target
|   "PkgConfig::WpeFDO" is imported but not globally visible.
| Call Stack (most recent call first):
|   platform/drm/CMakeLists.txt:9 (find_package)

@aperezdc, any change in the CMake versions compatibility lately?

update: here we have a smoking gun https://github.com/Igalia/cog/commit/32d6d5b39a2e4830d145ec9274f73c746a51aac5

update2: but in theory the provided by dunfell (3.16 - https://github.com/yoctoproject/poky/blob/dunfell/meta/recipes-devtools/cmake/cmake_3.16.5.bb) satisfies the minimum version 3.12 required for the Cog CMake rules.

psaavedra commented 1 year ago

Replaced by https://github.com/Igalia/meta-webkit/pull/397

Igalia / meta-webkit

Fix dependencies from cog and other recipes with libsoup/libsoup-2.4 #394