Igalia / meta-webkit

Yocto / OpenEmbedded layer for WebKit based engines and browsers
MIT License
125 stars 67 forks source link

cog: Add 0.16 recipe with meson support #414

Closed psaavedra closed 1 year ago

psaavedra commented 1 year ago

Reported-by: Guillaume Emont guijemont@igalia.com

guijemont commented 1 year ago

Side comment: cog 0.16 doesn't work with drm platform. We might want to include this patch that is supposed to fix it: https://github.com/Igalia/cog/commit/9c9b361c34f3391c11843f060564151768e222b5

aperezdc commented 1 year ago

Side comment: cog 0.16 doesn't work with drm platform. We might want to include this patch that is supposed to fix it: Igalia/cog@9c9b361

Alternatively, go directly to version 0.16.1, which includes this fix 😉

guijemont commented 1 year ago

Alternatively, go directly to version 0.16.1, which includes this fix wink

Oh, indeed, now that it's released, I think that's what we should do.

psaavedra commented 1 year ago

Tests passed. An approval from @manuelafm received. @guijemont do you want to do a additional r? if not I'll go move this forward and land the changes finally in main

guijemont commented 1 year ago

Tests passed. An approval from @manuelafm received. @guijemont do you want to do a additional r? if not I'll go move this forward and land the changes finally in main

LGTM. I didn't look in detail at every line thinking of all corner cases, but when I tested an older version of the patch (manually fixing the checksum) it worked, and the differences brought by the new version look correct.