wpewebkit 2.38.4 build failure

[Oquirella]

Building the master branch:

/build/tmp/work/aarch64-mx8mp-poky-linux/wpewebkit/2.38.4-r0/wpewebkit-2.38.4/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: error: 'GST_VIDEO_TRANSFER_BT601' was not declared in this scope; did you mean 'GST_VIDEO_TRANSFER_BT709'?

[JanLochi]

I have the same issue on dunfell. Looks like the symbol GST_VIDEO_TRANSFER_BT601 was added in gstreamer 1.18. I have something not as recent...

[clopez]

This should be fixed by wpewebkit 2.38.5

PR at https://github.com/Igalia/meta-webkit/pull/454

[JanLochi]

thx @clopez

In the meantime, I was able to compile with this patch (recipes-extended/wpewebkit/files/0001_incompatibleGstreamerColorimetry.patch) :

diff --git a/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp b/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
index 8c690511e564..38dec38884fa 100644
--- a/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
+++ b/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
@@ -857,7 +857,7 @@ void fillVideoInfoColorimetryFromColorSpace(GstVideoInfo* info, const PlatformVi
             GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT709;
             break;
         case PlatformVideoTransferCharacteristics::Smpte170m:
-            GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601;
+            GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT709;
             break;
         default:
             break;

[JanLochi]

@clopez I can confirm that the issue is no longer present on 84ee06d1df77801984b0c16f9f17edc0a83257fa

[psaavedra]

Fixed on https://github.com/Igalia/meta-webkit/commit/84ee06d1df77801984b0c16f9f17edc0a83257fa