search

Igalia / meta-webkit

Yocto / OpenEmbedded layer for WebKit based engines and browsers
MIT License
125 stars 66 forks source link

wpewebkit: gst videoconvert/videoscale plugins were merged into one. #460

Closed clopez closed 1 year ago

clopez commented 1 year ago

A new plugin named gstreamer1.0-plugins-base-videoconvertscale contains the previous plugins videoconvert/videoscale merged.

Since Yocto >= Mickledore (4.2) ( Yocto commit 4e07f56dced0b06d2cb60530e3989f656eede2cd or OE-Core rev: fb2d28e0315ece6180c87c7047587673024a09f7 )

Fixes: #459

clopez commented 1 year ago

Ok, the CI passes.

There is this build failure at https://github.com/Igalia/meta-webkit/actions/runs/4480404588/jobs/7879268376?pr=460 but seems unrelated (this patch doesn't touch wpewebkit do_build or do_configure tasks, only the runtime_depends list)

2023-03-21T19:07:51.1190980Z | /home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-wpe-2-38/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/2.38.5-r0/build/JavaScriptCore/PrivateHeaders/JavaScriptCore/ARMv7Assembler.h:3085:34: warning: bitwise operation between different enumeration types 'JSC::ARMv7Assembler::OpcodeID1' and 'JSC::ARMv7Assembler::RegisterID' {aka 'JSC::ARMRegisters::RegisterID'} is deprecated [-Wdeprecated-enum-enum-conversion]
2023-03-21T19:07:51.1192732Z |  3085 |             m_buffer.putShort(op | reg1);
2023-03-21T19:07:51.1193223Z |       |                               ~~~^~~~~~
2023-03-21T19:07:51.1193685Z | {standard input}: Assembler messages:
2023-03-21T19:07:51.1194314Z | {standard input}:26162: Warning: end of file not at end of a line; newline inserted
2023-03-21T19:07:51.1195629Z | {standard input}: Error: .size expression for _ZN7WebCore28JSDecompressionStreamDecoderC2EPN3JSC9StructureERNS_17JSDOMGlobalObjectEON3WTF3RefINS_26DecompressionStreamDecoderENS6_12RawPtrTraitsIS8_EEEE does not evaluate to a constant
2023-03-21T19:07:51.1197273Z | arm-poky-linux-gnueabi-g++: fatal error: Killed signal terminated program cc1plus
2023-03-21T19:07:51.1198161Z | compilation terminated.

Demangled:

$ cat build_log|grep 'constant'|c++filt 
2023-03-21T19:07:51.1195629Z | {standard input}: Error: .size expression for WebCore::JSDecompressionStreamDecoder::JSDecompressionStreamDecoder(JSC::Structure*, WebCore::JSDOMGlobalObject&, WTF::Ref<WebCore::DecompressionStreamDecoder, WTF::RawPtrTraits<WebCore::DecompressionStreamDecoder> >&&) does not evaluate to a constant
psaavedra commented 1 year ago

Good finding. LGTM . Thanks for the PR.

Just for keep the cross-reference, this change comes motivated by this one on Poky: https://git.yoctoproject.org/poky/commit/meta/recipes-multimedia/gstreamer?id=4e07f56dced0b06d2cb60530e3989f656eede2cd