Igalia / meta-webkit

Yocto / OpenEmbedded layer for WebKit based engines and browsers
MIT License
126 stars 69 forks source link

wpewebkit,webkitgtk: bump to version 2.40.0 #463

Closed manuelafm closed 1 year ago

manuelafm commented 1 year ago

This is the first stable release in the 2.40 series.

webkitgtk:

wpewebkit specific:

manuelafm commented 1 year ago

@clopez & @psaavedra : feel free to push modifications or take over.

psaavedra commented 1 year ago

There is an error for webkitgtk:

CMake Error at /home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.40.0-r0/recipe-sysroot-native/usr/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
|   Could NOT find Unifdef (missing: UNIFDEF_EXECUTABLE)
| Call Stack (most recent call first):
|   /home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.40.0-r0/recipe-sysroot-native/usr/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
|   Source/cmake/FindUnifdef.cmake:12 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
|   Source/cmake/WebKitFindPackage.cmake:44 (_find_package)
|   Source/cmake/OptionsGTK.cmake:28 (find_package)
|   Source/cmake/WebKitCommon.cmake:227 (include)
|   CMakeLists.txt:21 (include)
| 
| 
| -- Configuring incomplete, errors occurred!
| See also "/home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.40.0-r0/build/CMakeFiles/CMakeOutput.log".
| See also "/home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.40.0-r0/build/CMakeFiles/CMakeError.log".
| WARNING: exit code 1 from a shell command.
NOTE: recipe webkitgtk-2.40.0-r0: task do_configure: Failed

I think both recipes (> 2.38) requires: DEPENDS = " ... unifdef-native"

psaavedra commented 1 year ago

@clopez & @psaavedra : feel free to push modifications or take over.

Since you did the initial effort. I'd prefer to let you finish the work.

clopez commented 1 year ago

Build failure from langdale-raspberrypi3-mesa-weston-gtk log:

 CMake Error at Source/cmake/OptionsGTK.cmake:507 (message):
|   libavif 0.9.0 is required for USE_AVIF.
| Call Stack (most recent call first):
|   Source/cmake/WebKitCommon.cmake:227 (include)
|   CMakeLists.txt:21 (include)
| 
| 
| -- Configuring incomplete, errors occurred!
| See also "/home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.40.0-r0/build/CMakeFiles/CMakeOutput.log".
| See also "/home/bot/yocto-webkit-langdale/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.40.0-r0/build/CMakeFiles/CMakeError.log".
| WARNING: exit code 1 from a shell command.
NOTE: recipe webkitgtk-2.40.0-r0: task do_configure: Failed
NOTE: recipe gtk+3-3.24.34-r0: task do_rm_work: Succeeded
NOTE: recipe gstreamer1.0-plugins-bad-1.20.5-r0: task do_package_qa: Succeeded
NOTE: recipe gstreamer1.0-plugins-bad-1.20.5-r0: task do_package_write_rpm: Succeeded
NOTE: Tasks Summary: Attempted 5226 tasks of which 702 didn't need to be rerun and 1 failed.

Summary: 1 task failed:
  /home/bot/yocto-webkit-langdale/sources/meta-webkit/recipes-browser/webkitgtk/webkitgtk_2.40.0.bb:do_configure
Summary: There were 3 WARNING messages.
psaavedra commented 1 year ago

BTW,probably you want to update the recipes to:

https://wpewebkit.org/release/wpewebkit-2.40.1.html https://webkitgtk.org/2023/04/20/webkitgtk2.40.1-released.html

psaavedra commented 1 year ago

... also related https://github.com/Igalia/meta-webkit/pull/464

manuelafm commented 1 year ago

@psaavedra ack to merge? I'd prefer to drop the recipes for 2.38.* or other changes later if you are OK with it (in fact I think that it would be useful to keep them for a few weeks/months at least, while they receive bugfix releases, some people might be using them).