WebKit version>2.38 needs unifdef and libavif during builds

Igalia / meta-webkit

Yocto / OpenEmbedded layer for WebKit based engines and browsers

MIT License

126 stars 69 forks source link

WebKit version>2.38 needs unifdef and libavif during builds #466

Closed woutervanh closed 10 months ago

woutervanh commented 1 year ago

As already applied in webkitgtk

philn commented 1 year ago

imho avif should become a new PACKAGECONFIG.

psaavedra commented 1 year ago

imho avif should become a new PACKAGECONFIG.

Yes, a packageconfig to set USE_AVIF ON/OFF and the corresponding depend with libavif.

https://github.com/WebKit/WebKit/blob/74b006a7fec7e2b21313fc6877e9200f7001d01e/Source/cmake/OptionsWPE.cmake#L47

Also, since this USE_AVIF is in WebKit at least since 2.34. I'd also suggest do it like this:

#in wpewebkit.inc
PACKAGECONFIG = "... avif"

PACKAGECONFIG[avif] = "-DUSE_AVIF=ON,-DUSE_AVIF=OFF,libavif`

manuelafm commented 1 year ago

Hi, I made changes to this in #468 but forgot to come back to this ticket... @woutervanh can you tell me if main is now working for you? And sorry if I ran over this change, we were testing several things in parallel.

woutervanh commented 10 months ago

is ok