Igalia / meta-webkit

Yocto / OpenEmbedded layer for WebKit based engines and browsers
MIT License
125 stars 66 forks source link

wpewebkit: Remove patch to FELightningNEON #471

Closed mdrodrigo closed 1 year ago

mdrodrigo commented 1 year ago

Remove patch to FELightningNEON. This commits removes the patch to FELightningNEON from recipe wpewebkit version 2.40. In this version of wpewebkit the patch is not correctly applied and causes a build error.

clopez commented 1 year ago

Which one is the build error? can you upload it somewhere and paste here the link to the log with the build error?

Also please describe your target machine (local.conf file)

mdrodrigo commented 1 year ago

Hi @clopez

The error is when the patch is applied in the source code. The error reported with the patch is below:

log.do_patch.126979.txt

The target machine in the local.conf is: MACHINE = 'raspberrypi4'

If you need any more information or testing, please contact me.

clopez commented 1 year ago

I see that the patch applies but with fuzz. It seems Yocto 4.2 Mickledore made this warning a fatal error by default:\

documentation/migration-guides/migration-4.2.rst-Patch QA checks
documentation/migration-guides/migration-4.2.rst-~~~~~~~~~~~~~~~
documentation/migration-guides/migration-4.2.rst-
documentation/migration-guides/migration-4.2.rst-The QA checks for patch fuzz and Upstream-Status have been reworked
documentation/migration-guides/migration-4.2.rst-slightly in this release. The Upstream-Status checking is now configurable
documentation/migration-guides/migration-4.2.rst-from :term:`WARN_QA` / :term:`ERROR_QA` (``patch-status-core`` for the
documentation/migration-guides/migration-4.2.rst-core layer, and ``patch-status-noncore`` for other layers).
documentation/migration-guides/migration-4.2.rst-
documentation/migration-guides/migration-4.2.rst:The ``patch-fuzz`` and ``patch-status-core`` checks are now in the default
documentation/migration-guides/migration-4.2.rst-value of :term:`ERROR_QA` so that they will cause the build to fail
documentation/migration-guides/migration-4.2.rst-if triggered. If you prefer to avoid this you will need to adjust the value
documentation/migration-guides/migration-4.2.rst-of :term:`ERROR_QA` in your configuration as desired.
clopez commented 1 year ago

The right fix is not to remove the patch but to update it to apply without fuzz

Can you try PR https://github.com/Igalia/meta-webkit/pull/472 to see if it fixes the issue for you?

mdrodrigo commented 1 year ago

Hi @clopez PR #472 worked fine for me, without compilation or patching errors. Wpewebkit worked fine too Thanks.

psaavedra commented 1 year ago

Closed in favour of #472