Possibly vestigial make targets have bitrotted

Igalia / pflua

Packet filtering in Lua

Other

313 stars 39 forks source link

Possibly vestigial make targets have bitrotted #155

Closed kbara closed 9 years ago

kbara commented 9 years ago

In src/Makefile, test:, test_jit_off:, and trace: have all bitrotted. Should they be fixed or removed? @dpino @andywingo

dpino commented 9 years ago

It seems this code is from when @jmunhoz was working in the benchmarking. If we haven't run these makes in the last months I believe is because they're no longer needed. I'd remove them.

kbara commented 9 years ago

Ok, cool. I've submitted a PR to remove them; it's not like they'd be hard to re-add if we did need them, but it looks like we don't.

kbara commented 9 years ago

The PR was merged and closed, so this should be too.