lhoist lifts more length checks in tail position

Igalia / pflua

Packet filtering in Lua

Other

313 stars 39 forks source link

lhoist lifts more length checks in tail position #190

Closed wingo closed 9 years ago

wingo commented 9 years ago

src/pf/optimize.lua (lhoist): In tail position, only the minimum packet length for the expression to be true is important. (selftest): Add a test.
doc/dst-host-192.68.1.1-and-greater-100.md: Regenerate.

Fixes #189.

wingo commented 9 years ago

rebased and regenerated

wingo commented 9 years ago

Rebased, and fixed to fold length checks in any subexpression, not just in test position. That way length hoisting can eliminate checks in tail position too.

kbara commented 9 years ago

LGTM, though I'll want to stress-test it after it's merged.