search

Igalia / pflua

Packet filtering in Lua
Other
313 stars 39 forks source link

Remove duplicated IPv4 parsing #235

Closed mpeterv closed 9 years ago

mpeterv commented 9 years ago

Since there is no port/address ambiguity anymore, when looking for an address bare numbers can always be interpreted as IPv4 addresses with one field. Therefore, special function for parsing IPv4 as 'net' argument can be removed.

Fixes issue: bare numbers as 'net' arguments were not interpreted correctly if there was more than one space after 'net'.

Fixes issue: hostnames starting with a number looking like a part of IPv4 were not interpreted correctly.

Added parser tests for fixed issues.

wingo commented 9 years ago

Great commit, lgtm with just that one nit. Can you please add that comment then I'll merge. Thank you!

mpeterv commented 9 years ago

Done and repushed.

wingo commented 9 years ago

Thanks again!