Add native dynasm backend

takikawa commented 7 years ago

This PR adds a dynasm backend for pflua. I'd appreciate any code review or comments, but here are some specific design points that I could use some feedback on:

Switching to the native backend uses a native = true key/value pair in the table passed to pf.compile. Is this a good idea or is there a better interface? Should native be default? (my feeling is no, since it is less mature)
I used environment variables in some places to enable native mode for tests (e.g., in pfquickcheck). Does that sound reasonable?
Currently targets just x64 with a unix ABI. Are there any other ABIs/ISAs that should definitely be supported? (either way it's probably a good idea to output a useful error though---or should it fall back to Lua?)

Also if I missed any tests that I should convert to also test the dynasm backend that would be good to know.

The main files that were added are pf/codegen.dasl, pf/regalloc.lua, and pf/selection.lua. I plan to squash commits before merging. An additional submodule was added for the Lua port of dynasm.

wingo commented 7 years ago

LGTM. I find the code really tasteful! Just one question about whether the .md files are up to date. Excellent work Asumu!

wingo commented 7 years ago

lgtm, let's do this!!!

takikawa commented 7 years ago

This is now squashed and merged as 4fbb6b509596ae616bcca747f8b6cc2d7d0a0d00 and ab88cf95d3945ee2c46516bc7f64acb96235b1d9.

Igalia / pflua

Add native dynasm backend #261