Igalia / pflua

Packet filtering in Lua
Other
313 stars 39 forks source link

Is dump-markdown (and the associated tests) broken? #265

Closed kbara closed 7 years ago

kbara commented 7 years ago

Looking at #251, I tried to manually run dump-markdown. doc/Makefile contains a lot of lines like ../tools/dump-markdown "proto 47" > $@.tmp && mv $@.tmp $@. However, when I try to invoke ../tools/dump-markdown, it fails:

% ../tools/dump-markdown "l1"
luajit: ../src/pf/codegen.lua:21: module 'dasm' not found:
        no field package.preload['dasm']
        no file './dasm.lua'
        no file '/home/abc/igalia/isnabbswitch/lib/luajit/usr/local/share/luajit-2.1.0-beta1/dasm.lua'
        no file '/usr/local/share/lua/5.1/dasm.lua'
        no file '/usr/local/share/lua/5.1/dasm/init.lua'
        no file '/home/abc/igalia/isnabbswitch/lib/luajit/usr/local/share/lua/5.1/dasm.lua'
        no file '/home/abc/igalia/isnabbswitch/lib/luajit/usr/local/share/lua/5.1/dasm/init.lua'
        no file '../src/dasm.lua'
        no file './dasm.so'
        no file '/usr/local/lib/lua/5.1/dasm.so'
        no file '/home/abc/igalia/isnabbswitch/lib/luajit/usr/local/lib/lua/5.1/dasm.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        ../src/pf/codegen.lua:21: in main chunk
        [C]: in function 'require'
        ../src/pf.lua:13: in main chunk
        [C]: in function 'require'
        ../tools/dump-markdown:5: in main chunk
        [C]: at 0x00404990

I have dasm.lua, in pflua/deps/dynasm, but it's not in the search path, as far as I can see.

I can reproduce this on an entirely clean checkout of pflua.

wingo commented 7 years ago

WFM on a fresh checkout. I think it works because of this in common.mk:

export LUA_PATH := $(ABS_TOP_SRCDIR)/deps/dynasm/?.lua;;
export LD_LIBRARY_PATH := $(ABS_TOP_SRCDIR)/deps/dynasm:$(LD_LIBARARY_PATH)

You don't see this on the command line as it's just an environment flag.