search

Igalia / snabb

Snabb Switch: Fast open source packet processing
Apache License 2.0
48 stars 5 forks source link

Missing argument in Manager:update_configuration #1157

Closed benagricola closed 6 years ago

benagricola commented 6 years ago

Just a quick one which I ran into implementing my own ptree support module - It looks like the call to support.update_mutable_objects_embedded_in_app_initargs (https://github.com/Igalia/snabb/blob/lwaftr/src/lib/ptree/ptree.lua#L535) is missing the schema name argument, causing various weirdness.

As far as I can tell this should always have the schema name passed, and it seems to work correctly once added. Happy to submit a PR with the fix but want to confirm I'm not missing something here :)

dpino commented 6 years ago

Thanks for reporting the issue. It seems to me too that the call is missing the schema_name argument. If you send a PR, and CI tests do not complain, I will merge it.