Igalia / snabb

Snabb Switch: Fast open source packet processing
Apache License 2.0
48 stars 5 forks source link

Randomize name parameter in test to avoid collisions #1181

Closed dpino closed 6 years ago

dpino commented 6 years ago

@eugeneia reported via Slack testlog/program.lwaftr.tests.selftest.sh has been failing in Snabb origin (See https://github.com/snabbco/snabb/pull/1382). It's known this test has shown interment failures in the past. I pulled the PR and run the test suite inside the container. Most of the times one subtest failed, some times two subtests failed. The tests that always failed were the ones related with snabb config.

I didn't properly identified the root of the problem, but I suspect the errors were caused to name collisions in the daemon name. So I modified the code to randomize the daemon name for each subtest. After this change, I run the test suite again several times and I wasn't able to reproduce the problem anymore. So I think this is the right fix.