search

Igalia / snabb

Snabb Switch: Fast open source packet processing
Apache License 2.0
48 stars 5 forks source link

CPU parsing should return an empty list if string is blank #1186

Closed dpino closed 5 years ago

takikawa commented 5 years ago

The change looks reasonable to me, but I'm not quite sure how to reproduce the issue. Is this for when available_cpus reads the system files and finds a blank file? Any reason to not also consider "" as blank for example? (like in ./snabb lwaftr run --cpu "" ... or something)

dpino commented 5 years ago

The error happens when there are not isolated CPUs in the system. In that case, the list of CPUs is an empty line. I agree the fix should also address an empty line. Possibly trimming the line is the right thing to do.

takikawa commented 5 years ago

LGTM. Looks like CI failed but is it just the recent snabbnfv test flakiness?

dpino commented 5 years ago

I rerun CI and this time it passed all tests.