Re-enable NUMA memory binding on newer kernels

Igalia / snabb

Snabb Switch: Fast open source packet processing

Apache License 2.0

47 stars 5 forks source link

Re-enable NUMA memory binding on newer kernels #1207

Closed wingo closed 5 years ago

wingo commented 5 years ago

lib/ljsyscall/syscall/linux/syscalls.lua: More robustly create multi-word bitmasks.
src/lib/numa.lua: Remove facility for blacklisting kernel versions. Re-enable bind_to_numa_node generally.

wingo commented 5 years ago

WDYT @takikawa, @eugeneia, and @dpino ?

eugeneia commented 5 years ago

I hate that this is so complicated, but this PR seems to make it simpler overall. :+1: Since this touches ljsyscall, maybe @justincormack has more insight.

eugeneia commented 5 years ago

I also wonder about our relation with upstream ljsyscall, we have https://github.com/snabbco/snabb/pull/1122 lying around. Would be nice to sync with upstream (both directions.)

wingo commented 5 years ago

Regarding upstream, there's https://github.com/justincormack/ljsyscall/pull/193 sitting around because I am a bad person and haven't done the last-mile there; so on the up side of things there won't be conflicts with upstream :P

justincormack commented 5 years ago

One problem about upstream is that I was reluctant to switch to LuaJit 2.1 branch as there has never actually been a proper release, and some of the PRs were not compatible due to syntactic differences. There are a couple of options, 1. fix the differences with some (probably a bit ugly) workarounds 2. drop support for the 2.0 branch 3. switch to raptorjit as the upstream...

wingo commented 5 years ago

I will try to get in the workarounds upstream.