lib.ptree: do not aggregate (ignore) counters that are symlinks

Igalia / snabb

Snabb Switch: Fast open source packet processing

Apache License 2.0

47 stars 5 forks source link

lib.ptree: do not aggregate (ignore) counters that are symlinks #1230

Closed eugeneia closed 4 years ago

eugeneia commented 4 years ago

This heuristic is intended to match global counters (e.g. intel_mp/pci device stats) which are shared by multiple app instances (via symlinking) and prevent them from being aggregated as if they were independent.

Prior to this snabb top showed bogus aggregations of per PCI device counters.

wingo commented 4 years ago

Merging and going to run some tests locally, given that buildbot is out to lunch :)

wingo commented 4 years ago

Seems to perform fine. Thanks!!

wingo commented 4 years ago

Unfortunately this commit makes it so that we no longer have counters for the intel app, as it does a symlink into /run/snabb/intel_mp to get its stats. Probably need to revert...