Igalia / snabb

Snabb Switch: Fast open source packet processing
Apache License 2.0
47 stars 5 forks source link

Revert "lib.ptree: do not aggregate (ignore) counters that are symlinks" #1232

Closed wingo closed 4 years ago

wingo commented 4 years ago

Reverts Igalia/snabb#1230. The problem is that if the manager doesn't aggregate counters that are targets of symlinks, it misses NIC counters associated with the intel_mp app, because the intel_mp app manages stats in a centralized place and has the different processes using the app symlink into the central stats repo.

The problem fixed by #1230 is that the manager ends up creating an erroneous global sum for NIC-wide stats such as rxdrop. However q1_rxdrop et al are fine, and the stats are fine in the worker directories. Therefore I am thinking that we can live with the bug until a more robust fix comes along.