search

Igalia / vkrunner

A shader script tester for Vulkan. Moved to https://gitlab.freedesktop.org/mesa/vkrunner
Other
43 stars 14 forks source link

Alternative uniform commands #49

Closed bpeel closed 5 years ago

bpeel commented 5 years ago

Adds the following commands:

push type offset values…

ubo binding subdata type offset values…

They are equivalent to the previous commands:

uniform type offset values…

uniform ubo binding type offset values…

The previous commands were named that way for compatibility with Piglit but the names are a bit confusing. They are however maintained for compatibility. The ubo subdata command is meant to be similar to the ssbo subdata command.

The branch also takes the opportunity to tidy up the process_test_line function because it was getting very large and unwieldy.

This was discussed in issue #47.

bpeel commented 5 years ago

I’ve pushed the patches that just tidy up the parser and don’t make any functional changes. The remaining two patches are left in this pull request in case anyone has any comments.

samuelig commented 5 years ago

I like these two patches, they follow the naming convention in vulkan (Push constants vs uniform variables) and make it clear the usage. Fee free to push them. We probably want to update too the users of VkRunner (piglit and CTS) once we push this.

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

bpeel commented 5 years ago

Thanks for the review. I’ve merged it.