search

Igalia / vkrunner

A shader script tester for Vulkan. Moved to https://gitlab.freedesktop.org/mesa/vkrunner
Other
43 stars 14 forks source link

Added support for long options #64

Closed hikiko closed 5 years ago

hikiko commented 5 years ago

With this branch we could support both long and short options using an MIT licensed getopt implementation. We can use unique negative numbers to denote options without a short option.

hikiko commented 5 years ago

Is there a good reason to put getopt file into a separate static library? Could we not just drop it directly into src/getopt.c and name it in VKRUNNERBIN_SOURCE_FILES?

No :) I just wasn't sure if I should put the "borrowed" files together with the others, I will move them.

I've found another issue as well, long options that don't have short options are ignored the way I've written it, I will fix that too.

Also I am writing here the two other things we discussed on IRC so that we have all the needed fixes together:

  1. I will edit the commit file to mention that this fixes issue 63
  2. Add a license in the getopt.c (if the author gives permission to do so).

Thank you!

bpeel commented 5 years ago

Thanks for making the changes. It looks good to me. Feel free to merge it.