Igalia / webkit-container-sdk

The all-in-one SDK for WebKit GTK/WPE port development.
MIT License
8 stars 4 forks source link

Add missing 'Adwaita' cursors to the container #19

Closed Scony closed 1 week ago

Scony commented 2 months ago

Required by https://github.com/WebKit/WebKit/pull/27024

TingPing commented 2 months ago

The theme is already mounted to /usr/local/share/icons.

We need to figure out why it’s not working.

Scony commented 2 months ago

The theme is already mounted to /usr/local/share/icons.

We need to figure out why it’s not working.

It is, but there are no cursors.

TingPing commented 2 months ago

Can you try setting the XCURSOR_PATH env var to include the /usr/local paths?

Scony commented 2 months ago

Can you try setting the XCURSOR_PATH env var to include the /usr/local paths?

I'll try

Scony commented 1 month ago

Can you try setting the XCURSOR_PATH env var to include the /usr/local paths?

It does not change anything. The "cursor lookup" algorithm we have in WebKit starts from /usr/local/share/icons/default anyway.

The problem is that even though we use /usr/local/share/icons/default to find the theme (which we do) following symlinks (/usr/local/share/icons/default/index.theme -> /etc/alternatives/x-cursor-theme -> /usr/share/icons/Adwaita/cursor.theme) we cannot find cursor icons under /usr/share/icons/Adwaita/cursors. This is because the cursors are part of adwaita-icon-theme-full package, see:

$ apt-file list adwaita-icon-theme-full
(...)
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/arrow
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bd_double_arrow
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_left_corner
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_right_corner
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_side
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_tee
(...)
TingPing commented 1 month ago

So ideally we didn't ship any part of Adwaita in the image, but it seems to be a hard dependency on a ton of things.

This works ln -s /usr/local/share/icons/Adwaita/cursors/ /usr/share/icons/Adwaita/cursors

nikolaszimmermann commented 1 week ago

Oops did not intent to approve sorry