search

Igalia / webkit-container-sdk

The all-in-one SDK for WebKit GTK/WPE port development.
MIT License
12 stars 7 forks source link

wkdev-update prints CWD errors if ran outside $WKDEV_SDK despite explictly mentioning $WKDEV_SDK #32

Closed ntrrgc closed 4 months ago

ntrrgc commented 4 months ago

How to reproduce:

  1. Run wkdev-update from a directory not inside $WKDEV_SDK.

Expected behavior: No errors.

Actual behavior: Several fatal: not a git repository that go away if ran inside $WKDEV_SDK, like here:

wkdev-update: Updates the wkdev-sdk Git repository and containers.

-> Updating Git repository 'wkdev-sdk' located in ${WKDEV_SDK}...
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

-> Updating image 'ghcr.io/igalia/wkdev-sdk:latest'...
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

docker.io/library/ubuntu:latest = ghcr.io/igalia/wkdev-sdk:latest
docker.io/library/ubuntu:latest = ghcr.io/igalia/wkdev-sdk:latest
registry.fedoraproject.org/fedora-toolbox:39 = ghcr.io/igalia/wkdev-sdk:latest
registry.fedoraproject.org/fedora-toolbox:39 = ghcr.io/igalia/wkdev-sdk:latest
ghcr.io/igalia/wkdev-sdk:latest = ghcr.io/igalia/wkdev-sdk:latest
ghcr.io/igalia/wkdev-sdk:latest = ghcr.io/igalia/wkdev-sdk:latest
-> Found 2 container(s) using the image 'ghcr.io/igalia/wkdev-sdk:latest', checking status:
   Container: pristine ⇾ OK        (image id 831dbb5363bd84e1da454c36ac0a0e0bbbdb9152a6e93fabe40daa3039d2e861)
   Container: wkdev    ⇾ OK        (image id 831dbb5363bd84e1da454c36ac0a0e0bbbdb9152a6e93fabe40daa3039d2e861)

-> No containers need to be re-created, all use the latest image version.

-> Finished.