Remove redundant and unwanted build checks

Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source

https://chromium.googlesource.com/chromium/src/

BSD 3-Clause "New" or "Revised" License

11 stars 6 forks source link

Remove redundant and unwanted build checks #115

Closed abhijeetk closed 3 weeks ago

abhijeetk commented 1 month ago

Currently, wolvic/BUILD.gn is accessible only to Android builds through an assert(is_android) check. This change removes unnecessary build configurations that were previously guarded by is_android an is_fuchsia, as they no longer seem relevant.

abhijeetk commented 1 month ago

@ns-mshin which option should I choose to merge commit ?

Squash and Merge or
Rebase and merge

ns-mshin commented 3 weeks ago

Hi, @abhijeetk, If you stack patches in your PR to address review comments, I'd like to suggest Squash and Merge. And if you stack them to handle different objective in same PR, it would be nice to rebase & merge to leave the patch's history in git. wdyt?