search

Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source
https://chromium.googlesource.com/chromium/src/
BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Wvr manager prepare land #24

Closed tiagovignatti closed 1 year ago

tiagovignatti commented 1 year ago

Hi back! This continues my changes in preparation for the WebXR shared buffer transport work coming next.

Just like my previous PR, there are no functional changes in this PR. I've tested this using Meta Quest 2 on WebXR Samples and other immersive experiences from Wolvic init page. PTAL.

zakharvoit commented 1 year ago

nit: I think some files are not formatted with Chromium style (I know that we didn't follow that too strictly in the past). I would suggest running "clang-format -i " at least for the new files but ideally for all changed files unless it generates too much noise.

tiagovignatti commented 1 year ago

Unfortunately I couldn't find a better way to rebase this branch (wvr-manager-prepare-land) on top of the newest wolvic_experimental, so I've rebased locally and forced a push my changes into wvr-manager-prepare-land.

Regardless, I believe I've addressed all the review comments now. I'll proceed and merge. Thank you!