Closed svillar closed 1 year ago
There are a few good resources where to test these changes:
We need to get the input state class split out of WvmManager. See https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/vr/input_delegate.h as a reference, specially the classes extending it. Do you mind looking into that @svillar, given that you're revamping the input source management? Thank you very much.
We need to get the input state class split out of WvmManager. See https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/vr/input_delegate.h as a reference, specially the classes extending it. Do you mind looking into that @svillar, given that you're revamping the input source management? Thank you very much.
Would you mind if we do that in a follow-up? I think it's a good idea to have first the correct implementation with the current structure, and then we could refactor it. Doing both things at once could complicate future rebases/blames/etc...
The input source management was not correct. There were some bugs in the current implementation and there are also some missing very important features.
This PR implements the following:
Note: the index for where the data for a particular button is located follows the xr-standard gamepad mapping that can be found https://www.w3.org/TR/webxr-gamepads-module-1/#xr-standard-gamepad-mapping