Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source
https://chromium.googlesource.com/chromium/src/
BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Revamp input source management #34

Closed svillar closed 1 year ago

svillar commented 1 year ago

The input source management was not correct. There were some bugs in the current implementation and there are also some missing very important features.

This PR implements the following:

Note: the index for where the data for a particular button is located follows the xr-standard gamepad mapping that can be found https://www.w3.org/TR/webxr-gamepads-module-1/#xr-standard-gamepad-mapping

svillar commented 1 year ago

There are a few good resources where to test these changes:

tiagovignatti commented 1 year ago

We need to get the input state class split out of WvmManager. See https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/vr/input_delegate.h as a reference, specially the classes extending it. Do you mind looking into that @svillar, given that you're revamping the input source management? Thank you very much.

svillar commented 1 year ago

We need to get the input state class split out of WvmManager. See https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/vr/input_delegate.h as a reference, specially the classes extending it. Do you mind looking into that @svillar, given that you're revamping the input source management? Thank you very much.

Would you mind if we do that in a follow-up? I think it's a good idea to have first the correct implementation with the current structure, and then we could refactor it. Doing both things at once could complicate future rebases/blames/etc...