search

Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source
https://chromium.googlesource.com/chromium/src/
BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Workaround to support older versions of three.js #36

Closed zakharvoit closed 4 months ago

zakharvoit commented 1 year ago

Older versions of three.js (until r125) have the following issue https://github.com/mrdoob/three.js/issues/21126 present which breaks certain WebXR experiences like "moonrider" and "construct chess".

This workaround makes sure that any WebGL context is marked as XR compatible when possible which means that applications no longer have to mark it manually and in the correct order. This fix is verified to work on both "moonrider" and "construct chess" and also doesn't break sample WebGL pages that don't use WebXR.

svillar commented 1 year ago

Please do not land this until we have discarded all the alternatives

zakharvoit commented 1 year ago

I'll convert this to a draft since we agreed it's better to fix this issue in moonrider and construct chess rather than in Wolvic. For now we can manually cherry-pick this change for test builds if needed.

svillar commented 4 months ago

I'll close this as it is no longer needed after the M124 update.