Fix crash when navigating in incognito mode

Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source

https://chromium.googlesource.com/chromium/src/

BSD 3-Clause "New" or "Revised" License

11 stars 6 forks source link

Fix crash when navigating in incognito mode #52

Closed zakharvoit closed 10 months ago

zakharvoit commented 10 months ago

The crash is happening in debug mode and is caused by hitting NOTREACHED: https://source.chromium.org/chromium/chromium/src/+/main:components/visitedlink/browser/visitedlink_writer.cc;l=324;drc=5eb14ef3da3c6dbcb0aa38372ad1cfafb85512c8 since Chromium doesn't allow saving visited links in incognito mode.

zakharvoit commented 10 months ago

Instead of changing this why not adding a new condition to WolvicContents::DisFinishNavigation()? We have several of them there and I think it fits much better

Good idea! I moved the condition to WolvicContents. PTAL