search

Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source
https://chromium.googlesource.com/chromium/src/
BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Use vsync of Wolvic #75

Closed mshin-wolvic closed 8 months ago

mshin-wolvic commented 8 months ago

This patch fixes the issue that does not reflect the frame skip of the web page's intention by using vsync of wolvic. If the frame skip is requred, then dropFrame will be true, and Chromium will wait a next tick of vsync in wolvic side, and then will get a new frame's information.

mshin-wolvic commented 8 months ago

I wonder why we need the dropped frame count. Couldn't we implement it just by checking that the lastSubmittedFrameId and the new frame id are not consecutive?

When dropping the frame, we want to skip drawing the frame to fix the white flash and want to finish the current tick and wait for the next tick to get the new frame's information. I couldn't find a way to do that with lastSubmittedFrameId and the new frame id. The previous patch changed to increase the the new frame id when the frame is submitted, the this patch changes to use the dropped frame count when the frame is missed.