search

Igalia / wolvic-chromium

The official GitHub mirror of the Chromium source
https://chromium.googlesource.com/chromium/src/
BSD 3-Clause "New" or "Revised" License
11 stars 6 forks source link

Introduce skippable navigation entries #76

Closed zakharvoit closed 6 months ago

zakharvoit commented 6 months ago

Allow browser to mark navigation entries as 'skippable' so that they are not used when performing back/forward navigation. This allows us to fix navigation issues caused by YouTube redirects to desktop app.

This change also fixes a crash which happened when rapidly clicking back/forward button multiple times by ensuring that any navigation doesn't go out of bounds.

Fixes #66

mshin-wolvic commented 6 months ago

I wonder if we can use canGoBack() before accessing goBack() to prevent CHECK crash.

zakharvoit commented 6 months ago

I wonder if we can use canGoBack() before accessing goBack() to prevent CHECK crash.

Yes, it was my idea originally. But since I replaced goBack() with goToOffset() it's not needed anymore. The canGoToOffset() check is performed inside findBackForwardNavigationOffset().