Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
796 stars 100 forks source link

Modernize deprecated getMetrics(DisplayMetrics) in Display #1223

Closed haanhvu closed 7 months ago

haanhvu commented 7 months ago

fix #799

haanhvu commented 7 months ago

I haven't tested in any Android 14 device yet. I don't have it either. Can we test through virtual device? https://developer.android.com/about/versions/14/get#large-screen-avd

HollowMan6 commented 7 months ago

I haven't tested in any Android 14 device yet. I don't have it either. Can we test through virtual device? https://developer.android.com/about/versions/14/get#large-screen-avd

It might be enough if we use the NoAPI variant via the virtual device, but it would be best if we somehow have some actual VR devices/simulators that use openXR for testing since the changes here are related to OffscreenDisplay.

svillar commented 7 months ago

BTW thanks for your first contribution! Very much appreciated!