search

Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
813 stars 105 forks source link

Implement Zoom UI in Hamburger Menu #1248

Closed mshin-wolvic closed 9 months ago

mshin-wolvic commented 9 months ago

Unlike the general menu items with ImageView&TextView layout, a Zoom menu has ImageView&TextView&+/- ImageViews layout and only +/- ImageViews should handle hover and click events. This patch configures the zoom layout and add the relevant code. The +/- ImageViews are connected to the page zoom feature, and this Zoom UI appears only in chromium-backend.

svillar commented 9 months ago

Ah and another comment, please add a % after the zoom level in the UI, otherwise seeing 100, 175 etc looks weird

svillar commented 9 months ago

Apart from that, the UI looks great and it works amazingly well!

mshin-wolvic commented 9 months ago

We are not adding translations in PRs anymore because that messes up Weblate, so let's just include the new strings in strings.xml and remove the translations.

Done.

Ah and another comment, please add a % after the zoom level in the UI, otherwise seeing 100, 175 etc looks weird

Done.

Thanks. :)