Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
796 stars 100 forks source link

Immersive start page, no Wolvic UI shown #1279

Open Utopiah opened 7 months ago

Utopiah commented 7 months ago

Is your feature request related to a problem? Please describe. I do no program natively but solely on the Web, mostly WebXR. I want to skip the OS UI to go straight to Wolvic. From there I can have a start page

Describe the solution you'd like Supporting it at all (if that's not already the case), then allowing it via setting option, if not as a command line option

Describe alternatives you've considered

Additional context

svillar commented 7 months ago

Duplicate of #1211 ?

Utopiah commented 7 months ago

Does #1211 concerns the start page or even opening via an adb command/intent?

My point being not of open Wolvic then navigating to an immersive WebXR page then opening it in XR (which I believe that other issue is about) but rather starting Wolvic and have e.g https://aframe.io/aframe/examples/boilerplate/hello-world/ directly in VR.

svillar commented 7 months ago

Does #1211 concerns the start page or even opening via an adb command/intent?

My point being not of open Wolvic then navigating to an immersive WebXR page then opening it in XR (which I believe that other issue is about) but rather starting Wolvic and have e.g https://aframe.io/aframe/examples/boilerplate/hello-world/ directly in VR.

Then you're talking about https://github.com/Igalia/wolvic/pull/1171

Utopiah commented 7 months ago

1171 provides a very interesting way to solve this indeed without touching much the code itself through the extension. I believe this is such a rare use case (for now) that instead of having the browser UI modified itself, just parameters is enough. Thanks for pointing it out!

So in my example @felipeerias would it mean

adb shell am start -n "com.igalia.wolvic/com.igalia.wolvic.VRBrowserActivity" \
    -a android.intent.action.MAIN                                             \
    -c android.intent.category.LAUNCHER                                       \
    -a android.intent.action.VIEW                                             \
    -d "https://aframe.io/aframe/examples/boilerplate/hello-world/"           \
    --ez open_in_immersive true                                               \
    --ez hide_webxr_interstitial true                                         \
    -e open_in_immersive_parent_xpath ''                                      \
    -e open_in_immersive_element_xpath '/html/body/a-scene/div[2]/button'

?

Finally @svillar do you imagine this PR would be reviewed soon? I have it in mind for https://github.com/Igalia/wolvic/issues/1103 but as I'm building myself for now I could just pull-in this patch.

svillar commented 6 months ago

Finally @svillar do you imagine this PR would be reviewed soon? I have it in mind for #1103 but as I'm building myself for now I could just pull-in this patch.

Sure, somehow it got its way in the middle of my work pile and didn't have a chance to get my attention. I'll review it sooner than later

svillar commented 6 months ago

Then I think this could be the same as #735 ?

LAGENCECREE commented 5 months ago

partially 🧐