search

Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
796 stars 100 forks source link

UI recentering issues #1370

Closed svillar closed 5 months ago

svillar commented 5 months ago

This PR tackles 3 different issues:

  1. View is recentered when setting headlock mode setting on startup
  2. View is not recentered when the head is moved while splash is shown
  3. Splash screen logo do not follow head orientation if the head moves before splash is shown
svillar commented 5 months ago

The code looks good but I could only verify it fixes 1 and 2. Could you please explain the change and how to verify it ? Thanks.

For 1 the issue is that when the head lock mode is set in the settings it was calling recenteryUIYaw(). As we did it on startup we were calling recenter always For 2 you have to start wolvic and the rotate your head before the splash is shown. Without the patch the logo could appear in the initial orientation of the head

javifernandez commented 5 months ago

The code looks good but I could only verify it fixes 1 and 2. Could you please explain the change and how to verify it ? Thanks.

For 1 the issue is that when the head lock mode is set in the settings it was calling recenteryUIYaw(). As we did it on startup we were calling recenter always For 2 you have to start wolvic and the rotate your head before the splash is shown. Without the patch the logo could appear in the initial orientation of the head

3) is the only one I've been unable to verify, sorry for not being clear.

svillar commented 5 months ago

The code looks good but I could only verify it fixes 1 and 2. Could you please explain the change and how to verify it ? Thanks.

For 1 the issue is that when the head lock mode is set in the settings it was calling recenteryUIYaw(). As we did it on startup we were calling recenter always For 2 you have to start wolvic and the rotate your head before the splash is shown. Without the patch the logo could appear in the initial orientation of the head

  1. is the only one I've been unable to verify, sorry for not being clear.

Oh sorry about that, totally my fault. I completely misread your comment. So 3 is similar to 2. in the sense that you need to rotate your head after starting the app but before the splash is shown. Without it the splash logo should point to the initial orientation, but with it it should be in front of you as usual.