search

Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
813 stars 105 forks source link

Use Khronos' OpenXR loader from Maven when supported #1405

Closed svillar closed 2 months ago

svillar commented 6 months ago

Most of the platforms used to distribute their own implementations/builds of the OpenXR loader. It was traditionally part of the propietary SDKs distributed by vendors. As they were under an EULA we had to keep them in a private repository only available to core devs (obviously any other external dev could download them on their own).

More recently, and driven by the AOSP flavor effort, we started to build the Khronos OpenXR loader from sources. Fortunatelly we got a well documented report explaining how to use the loader directly from the central Maven repository. This greatly simplifies the build process and also improves the open-source feel of the project by reducing our deps with the third-party repo.

So far this option is now available for the following flavors:

It does not work for neither HVR, nor SnapdragonSpaces based devices nor Pico. For these ones we still need to rely on the loader from the SDK.

Fixes #1394

svillar commented 6 months ago

Note that this requires firmware v62+ in Meta devices. It's easy to check that in OpenXR but it's likely too late. I'd love to have some "external" mechanism to prevent/filter out Wolvic from executing depending on the firmware version. v62 is from February so perhaps a bit risky to enable it in a release in the following moths.

svillar commented 2 months ago

The commit message of the second commit is incomplete:

"Should the test fail, a dialog with a text asking user to upgrade the" ....

Good catch, updated.

svillar commented 2 months ago

In quest there is a system window that appears before showing Wolvic's logo. I doesn't show for too long, but it's clearly noticeable.

In other systems (eg, Pico) this window it's not shown, though.

Do you think that's a blocker?

javifernandez commented 2 months ago

In quest there is a system window that appears before showing Wolvic's logo. I doesn't show for too long, but it's clearly noticeable. In other systems (eg, Pico) this window it's not shown, though.

Do you think that's a blocker?

I wouldn't say it's a blocker to merge it in main, but I wouldn't select for any stable release without a solution for this issue.