search

Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
796 stars 100 forks source link

Can't bookmark pages that don't have a <title> tag or have an empty <title> tag. #1439

Open Kate6 opened 3 months ago

Kate6 commented 3 months ago

Configuration

Wolvic version: 1.6.1 Wolvic build ID:

Hardware: Meta Quest 2

Steps to Reproduce

  1. Visit a page that has an empty tag or doesn't have a <title> tag.</li> <li>Click the little star icon next to the address bar to bookmark the page.</li> <li>Click the "Library" icon on the Wolvic toolbar and bring up the bookmarks.</li> </ol> <h2>Current Behavior</h2> <!--- If describing a bug, tell us what happens instead of the expected behavior. --> <!--- If suggesting a change/improvement, explain the difference from current behavior. --> <p>When bookmarking a page that either doesn't have a <title> tag or has an empty <title> tag, the little star icon does fill in to indicate that the page has been bookmarked, but the page does not actually appear in the list of bookmarks.</p> <h2>Expected Behavior</h2> <!--- If you're describing a bug, tell us what should happen. --> <!--- If you're suggesting a change/improvement, tell us how it should work. --> <p>I would expect pages without a <title> tag or with an empty <title> tag to still appear in bookmarks, perhaps by their URL instead of by the page title.</p> <h2>Possible Solution</h2> <!--- [Optional] --> <!--- Feel free to suggest a fix/reason for the bug, --> <!--- or ideas how to implement the addition or change. --> <h2>Context</h2> <!--- [Optional] --> <!--- How has this issue affected you? What are you trying to accomplish? --> <!--- Providing context helps us come up with a solution that is most useful in the real world! :) --> <h2>Error Logs and Stack Traces</h2> <!--- [Optional] --> <!--- These are very useful for quickly identifying the causes for bug fixes. --> <!--- In Developer Mode, run `adb logcat` to capture potentially useful logs. --> <details open> <!--- DO NOT REMOVE THIS LINE. --> ``` ``` <!--- DO NOT REMOVE THIS LINE. --> </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/svillar"><img src="https://avatars.githubusercontent.com/u/1826122?v=4" />svillar</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <p>Thanks @Kate6 for the report. Any actual page in the wild that could serve as an example? Otherwise we'd just use a local one.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Kate6"><img src="https://avatars.githubusercontent.com/u/1279503?v=4" />Kate6</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <p>The pages I encountered this with were actually all parts of little LAN-local applets I'd written for my own personal use. Once I realized this was why they weren't showing up in Wolvic's bookmarks I actually went through and changed them all to have non-empty <title> tags, which solved the problem for me personally. </p> <p>Still seemed like a definite bug though so I thought I'd report it.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/shynekomaid"><img src="https://avatars.githubusercontent.com/u/34548743?v=4" />shynekomaid</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <p>The title tag is an important and obligatory part of the website structure. As a solution, I can recommend adding a bookmark to another resource and changing the link</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/Kate6"><img src="https://avatars.githubusercontent.com/u/1279503?v=4" />Kate6</a> commented <strong> 3 months ago</strong> </div> <div class="markdown-body"> <p>As per <a href="https://html.spec.whatwg.org/multipage/semantics.html#the-title-element">the HTML standard</a>, "If it's reasonable for the <a href="https://html.spec.whatwg.org/multipage/dom.html#document">Document</a> to have no title, then the <a href="https://html.spec.whatwg.org/multipage/semantics.html#the-title-element">title</a> element is probably not required."</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>