search

Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
796 stars 100 forks source link

[OpenXR] Workaround phantom click events with hand interaction #1472

Closed svillar closed 2 months ago

svillar commented 2 months ago

This PR tries to workaround the phantom clicks we get from the MagicLeap OpenXR runtime when moving the hands out of sight and using the hand interaction profile.

First of all it reverts the previous attempt to solve this as it was not working fine. Then it implements a new solution based on gesture detection. We now require a detection of the gesture of the hands facing the head from the hand joints data.

svillar commented 2 months ago

The change looks good and I've already tried and solves most of the cases.

However, do the 3 commits make sense now ? Haven't you reverted the workaround in the last commit ?

The first commit is the revert. The 2nd is the fix and the 3rd is a nice followup which I agree is kind of unrelated, but I found it while developing this one.

javifernandez commented 2 months ago

The change looks good and I've already tried and solves most of the cases. However, do the 3 commits make sense now ? Haven't you reverted the workaround in the last commit ?

The first commit is the revert. The 2nd is the fix and the 3rd is a nice followup which I agree is kind of unrelated, but I found it while developing this one.

But my question is whether we should squash them, at least the revert.

svillar commented 2 months ago

The change looks good and I've already tried and solves most of the cases. However, do the 3 commits make sense now ? Haven't you reverted the workaround in the last commit ?

The first commit is the revert. The 2nd is the fix and the 3rd is a nice followup which I agree is kind of unrelated, but I found it while developing this one.

But my question is whether we should squash them, at least the revert.

Oh I think it's good to have them as separate commits. It's cleaner from the history POV