search

Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
813 stars 105 forks source link

Wolvic is too bright #1479

Closed yuripourre closed 2 months ago

yuripourre commented 4 months ago

Configuration

Wolvic version: trunk Wolvic build ID:

Hardware: Oculus Quest 2

Steps to Reproduce

  1. Open Wolvic
  2. Access any page
  3. Confirm the page is too bright

Current Behavior

The web page is too bright, specially comparing to the Oculus Browser

Expected Behavior

Page has regular brightness

Possible Solution

Set default brightness to a lower value

Context

The image below shows Wolvic on top and Oculus browser in the bottom. Wolvic is clearly very bright.

image showing the same page in oculus browser and Wolvic

Error Logs and Stack Traces

``` ```
svillar commented 4 months ago

Hmm I doubt there are differences caused by Chromium there. Have you tried the Gecko version?

yuripourre commented 4 months ago

Hmm I doubt there are differences caused by Chromium there. Have you tried the Gecko version?

No, I couldn't build gecko-dev. I can try to download the gecko version and compare.

Is there any way to change the brightness via code? I've found some methods but calling them didn't have any noticable effect.

svillar commented 4 months ago

Hmm I doubt there are differences caused by Chromium there. Have you tried the Gecko version?

No, I couldn't build gecko-dev. I can try to download the gecko version and compare.

Is there any way to change the brightness via code? I've found some methods but calling them didn't have any noticable effect.

We haven't used gecko-dev for a while. You don't actually need to build it as long as you don't use WebXR. For a non-WebXR enabled Wolvic you can just use the version from Maven. It should work out of the box

svillar commented 3 months ago

It is not a problem with chromium. Check the following two screenshots, top is with Chromium bottom with Gecko. Both taken in a Pico4. I'll check later with a Meta device, because I know we have specific code for gamma there and that might be the issue Screenshot_com igalia wolvic dev_2024 07 30-10 12 53 598_801 Screenshot_com igalia wolvic_2024 07 30-09 51 37 890_343

svillar commented 3 months ago

@yuripourre are you sure you didn't change anything in the code? I cannot see any difference in brightness. I'm attaching 3 new pictures, the first two using Wolvic with chromium and gecko and the last one the Meta browser. 54 55 57

yuripourre commented 3 months ago

@svillar thanks for investigating!

I didn't change anything, I compiled as-is. I will try pull master again e make a new test.

I can also try in another device, just in case. I will let you know.

svillar commented 3 months ago

@svillar thanks for investigating!

I didn't change anything, I compiled as-is. I will try pull master again e make a new test.

I can also try in another device, just in case. I will let you know.

Have you verified the issue?

yuripourre commented 3 months ago

@svillar Hi, I didn't verify yet. I am sorry, busy weeks.

I will update here when I test it.

svillar commented 2 months ago

@yuripourre news?

yuripourre commented 2 months ago

@svillar I am sorry, I've been focusing in other projects, I will close this issue, if I make time to test it and the problem persists I can reopen.

Thank you so much for taking time to investigate it.