Igalia / wolvic

A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://wolvic.org
Mozilla Public License 2.0
813 stars 105 forks source link

The size of the fullscreen window is reset whenever we leave fullscreen mode #1593

Open felipeerias opened 2 weeks ago

felipeerias commented 2 weeks ago

Steps to Reproduce

  1. Play a video in e.g. YouTube
  2. open fullscreen mode
  3. change the size of the fullscreen window to e.g. 3X
  4. leave fullscren mode
  5. open again fullscreen mode

Note: the video keeps playing the whole time.

Current Behavior

The fullscreen window has the default size.

Expected Behavior

The fullscreen window has the last size that we selected (3X).

Possible Solution

Store the size of the fullscreen window and use it as the default when entering fullscreen mode.

haanhvu commented 2 days ago

I'll work on this

haanhvu commented 4 hours ago

Current Behavior

The fullscreen window has the default size.

I have studied the code and also tried out different cases. It doesn't seem like full screen window has a default size, but instead depends on the current size of the normal window, and fullscreen window is a a bit bigger and closer than normal window?

This was what I saw:

So AFAIU the issue is about making the resizing of fullscreen separate from the size of normal screen?

Actually as a user I'd prefer to have the resizing of fullscreen dependent on the current size of normal screen. If the current size of normal screen is small (1x) then suddenly the size of fullscreen is so large (3x) and close, my eyes wouldn't feel comfortable. I'd prefer the fullscreen size to depend on the current normal size first, then I could resize later, no matter what was the last fullscreen size. Wdyt :thinking: