I see many in-progress parts here - I won't accept it as-is. Unfinished parts are a real pain to deal with - an absolutely-never-happened-to-me imaginary example will be when you leave some unfinished parts and never actually finish it, so the main repo ends up in a bad state. Also, do not add new commits to a pull request while it is already submitted - I don't know now which parts I already reviewed, and which parts are new.
I don't want to discourage you from writing, you are cool and very helpful, so let's do it like this: I will close this pull request without merging, you will open a new one without unfinished parts (you can finish them or delete them from your repo) and write a good-enough changelog. I will review it, you'll fix what I'll find and we'll be best buddies since then and for eternity.
TheParaziT
commented
2 years ago
I see many in-progress parts here - I won't accept it as-is. Unfinished parts are a real pain to deal with - an absolutely-never-happened-to-me imaginary example will be when you leave some unfinished parts and never actually finish it, so the main repo ends up in a bad state. Also, do not add new commits to a pull request while it is already submitted - I don't know now which parts I already reviewed, and which parts are new.
I don't want to discourage you from writing, you are cool and very helpful, so let's do it like this: I will close this pull request without merging, you will open a new one without unfinished parts (you can finish them or delete them from your repo) and write a good-enough changelog. I will review it, you'll fix what I'll find and we'll be best buddies since then and for eternity.