IgnisDa / npm-libs

A set of packages for different javascript needs
https://www.npmjs.com/~ignisda
MIT License
8 stars 6 forks source link

fix(remix-pagination): preserve multiple values for search params #4

Open mquinnv opened 1 year ago

mquinnv commented 1 year ago

prior to this patch, URLSearchParams was being passed through Object.entries, which makes multiple values for the same param, e.g. q=3&q=4&q=5, be replaced with only one entry q=5. using URLSearchParams for the entire process of creating the page link (instead of the ufo library) resolves this problem

fixes #3

IgnisDa commented 1 year ago

Thank you! It looks like this removes the ufo dependency. If yes, could you please also remove it from package.json?

mquinnv commented 1 year ago

i think i did that properly. i've not used pnpm or this build system before