search

IgnisDa / ryot

Roll your own tracker!
https://ryot.io
GNU General Public License v3.0
1.88k stars 48 forks source link

[Feature Request] - Better Comic book metadata #1044

Open zanish opened 1 day ago

zanish commented 1 day ago

I am currently using League of Comic Geeks and attempting to move all tracking to Ryot. Comic books unfortunately seem to need to use OpenLibrary metadata which is pretty bad for comics. There are better options but would require set up of an API token by the user much like how video games twitch client setup is. I use a tool called comictagger and they've been solid, they have a write up on comic book meta information here: https://github.com/comictagger/comictagger/wiki/Comic-and-Manga-Information-Sources. I'll summarize my personal preferences below.

Option 1: ComicVine ComicVine actually doesn't require an api token but would rate limit. Easy to use, only downside is there is no standard on how to handle TPBs, whether they are their own series or included in the series with books. Shouldn't make too much of an issue as long as users could override series.

Option 2: Metron Used this a bit, but not enough to have a strong opinion. Seems to be solid though.

Option 3: leagueofcomicgeeks I have an open question for them about API access and availability, looks like some have developed a unofficial api in the past so they may consider support in the future if it's not available.

IgnisDa commented 1 day ago

Ryot is a commercial project. Do these APIs allow access from such projects for free?

zanish commented 1 day ago

Would it change for self hosters vs cloud user?

I am not sure as Metron just says they have the right to refuse use, but no mention of commericial ban.

Comic Vine's api is publiclly rate limited and I see no verbiage stopping commercial use, but IANAL and don't know much about commercial area. They are a corporation so I'd guess they'd want a contract agreement.

This could be possibly partially solved by letting users add their own metadata providers and supporting the different comic tagging standards (I think there are only 3 widely used ones). Then users could use their personal accounts and api keys only for them and not for commercial use?

IgnisDa commented 11 hours ago

Comicvine clearly states that they are not open to support commerical projects: https://comicvine.gamespot.com/api/

Metron API does not mention commercial usage, so it might be possible. But looking through Reddit, I find people complaining that their database is not well mantained.

This could be possibly partially solved by letting users add...

Depends on how Comicvine decides to look at this situation, but I doubt they would consider this usecase. In any case, I don't have the bandwidth to contact them and clear it up. If you are willing to clear things up with them, then I give you permission to do so on this project's behalf.

zanish commented 1 hour ago

This is only an issue due to pro and cloud right?

So if it doesn't support commercial use, then could you allow users to add their own metatdata agents? Then as a self-hoster who is not paying. We can add plug-ins/metadata agents that would be available only to non-commercial users?

IgnisDa commented 33 minutes ago

Ideally yes. But as I stated, this is up to their discretion.