IgniteUI / ignite-ui

Ignite UI for jQuery by Infragistics
https://bit.ly/2kuu1fT
Other
477 stars 83 forks source link

Combo is not showing items visually correct #2174

Closed Volen99 closed 2 years ago

Volen99 commented 2 years ago

Description

Combo items are not displayed visually correct.

Steps to reproduce

  1. Go to this JsFiddle
  2. Open the Combo and observe

Result

image

Expected result

image

hanastasov commented 2 years ago

Possibly related to https://github.com/IgniteUI/ignite-ui/issues/2154

hanastasov commented 2 years ago

@Volen99 found that the fix for #2119 and #2124 is the reason why items are cut off. This PR reverts this fix, but this leads to #2119 again.

Summary of our investigation:

  1. 2124 is reproducible in 20.1, but is not reproducible in 22.1, even without the "fix", so let's ignore this issue for now.

  2. Don't remove the fix for #2119 . Instead, set height using custom css. See if visibleItemsCount works properly. If not, investigate if setting the height is the reason for this, or something else in the code.
  3. If setting a height breaks the visibleItemsCount, then just removes this fix, and will suggest a custom work around for #2119
  4. In the end, retest all bugs - #2174, #2119 and #2124